Add imagePullSecrets to predeploy tests#29340
Closed
ebdekock wants to merge 2 commits intogravitational:masterfrom
Closed
Add imagePullSecrets to predeploy tests#29340ebdekock wants to merge 2 commits intogravitational:masterfrom
ebdekock wants to merge 2 commits intogravitational:masterfrom
Conversation
r0mant
approved these changes
Jul 20, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
@hugoShaka Mind taking a look at this as well?
hugoShaka
approved these changes
Jul 21, 2023
Contributor
Author
|
Thanks for the approvals! How do I proceed/get this merged? :) |
Contributor
Author
|
@jimbishopp @klizhentas @russjones @zmb3 Sorry for the mass ping, would one of you be able to assist in reviewing/approving so I can merge this in? Please let me know if theres something else I should be doing to get this merged! |
Collaborator
|
@hugoShaka can you buddy this one? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from this PR: #23927
They added imagePullSecrets to the deployments, but not the test jobs. This fixes it so that all pods will be able to pull the docker images from a private repo.